Fix a wierd behavior of a function #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Oct 6, 2024
There was a problem hiding this comment.
Refine the git commit message (including the typo: "wierd") and address the off-by-one error.
linD026
approved these changes
Oct 6, 2024
The procfile_write prints the content what user writes into. However, when the content size is greater than or equal to PROCFS_MAX_SIZE, procfile_write will print nothing, because the index for appending the tail NULL character will be modulo to 0, which is an off-by-one error. This fixes the problem by changing the upper bound of procfs_buffer_size to (PROCFS_MAX_SIZE - 1), leaving one byte for NULL character. After the change, we can discard the modulo because the range of procfs_buffer_size is already between 0 and (PROCFS_MAX_SIZE - 1).
|
Thank @NOVBobLee for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The procfile_write prints the content what user writes into. However, when the content size is greater than or equal to PROCFS_MAX_SIZE, procfile_write will print nothing, because the index for appending the tail NULL character will be modulo to 0.
So, I modify the code with 1. restrict the max acceptable content size to (PROCFS_MAX_SIZE - 1), left a space for NULL character 2. discard the modulo because we already restrict the max size to (PROCFS_MAX_SIZE - 1)